/cuberite

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code cleanup - clean version #1945

Merged
merged 6 commits into from May 8, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Woazboat @bearbin @SafwatHalaby @madmaxoft
@Woazboat
Contributor

Woazboat commented May 6, 2015

Was #1917
New changes from old pull request:
Cleaned up commits
Initialize Tracer::m_NormalTable on first use
clang warning overrides

@Woazboat Woazboat referenced this pull request May 6, 2015

Merged

Small code cleanup #1917

@madmaxoft

madmaxoft reviewed May 6, 2015
View changes

Show outdated Hide outdated src/Tracer.cpp
@madmaxoft

madmaxoft reviewed May 6, 2015
View changes

Show outdated Hide outdated src/Tracer.h
@madmaxoft

madmaxoft reviewed May 6, 2015
View changes

Show outdated Hide outdated src/Vector3.h
@bearbin

This comment has been minimized.

Show comment
Hide comment
@bearbin

bearbin May 8, 2015

Member

Is this good to merge?
Member

bearbin commented May 8, 2015

Is this good to merge?
@Woazboat

This comment has been minimized.

Show comment
Hide comment
@Woazboat

Woazboat May 8, 2015

Contributor

It is from my side. Looks like the coverage checker somehow got stuck though.
Contributor

Woazboat commented May 8, 2015

It is from my side. Looks like the coverage checker somehow got stuck though.

madmaxoft added a commit that referenced this pull request May 8, 2015

@madmaxoft
Merge pull request #1945 from Woazboat/CodeCleanup_refactored 
Small code cleanup - clean version
Loading status checks…
9329c2c

@madmaxoft madmaxoft merged commit 9329c2c into cuberite:master May 8, 2015
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SafwatHalaby

This comment has been minimized.

Show comment
Hide comment
@SafwatHalaby

SafwatHalaby May 9, 2015

Member

Coveralls.io is also stuck in #1968.
Member

SafwatHalaby commented May 9, 2015

Coveralls.io is also stuck in #1968.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment