New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathFinder - Couple of bugfixes #1946

Merged
merged 2 commits into from May 6, 2015

Conversation

Projects
None yet
2 participants
@SafwatHalaby
Member

SafwatHalaby commented May 6, 2015

Couple of fixes, each in its own commit.

-Min recalculate interval is now half second (There was no minimum limit, it was CPU-wasteful)
-Fixed mobs not reaching a player when the player's bounding box is in the air (e.g. leaning with SHIFT)
-Fixed cChunk issues with swimming.

@SafwatHalaby SafwatHalaby changed the title from PF - Fixed center in air issue to PathFinder - Fixed center in air issue May 6, 2015

wiseoldman95

@SafwatHalaby SafwatHalaby changed the title from PathFinder - Fixed center in air issue to PathFinder - Couple of bugfixes May 6, 2015

@bearbin

This comment has been minimized.

Show comment
Hide comment
@bearbin

bearbin May 6, 2015

Member

Is this tested and works?

If it is, LGTM.

Member

bearbin commented May 6, 2015

Is this tested and works?

If it is, LGTM.

@SafwatHalaby

This comment has been minimized.

Show comment
Hide comment
@SafwatHalaby

SafwatHalaby May 6, 2015

Member

I renamed the PR.
The changes are trivial, and I tested stuff for half an hour.
I'm pretty sure it's safe merge.

Member

SafwatHalaby commented May 6, 2015

I renamed the PR.
The changes are trivial, and I tested stuff for half an hour.
I'm pretty sure it's safe merge.

bearbin added a commit that referenced this pull request May 6, 2015

Merge pull request #1946 from SafwatHalaby/lean
PathFinder - Couple of bugfixes

@bearbin bearbin merged commit bd73dce into cuberite:master May 6, 2015

2 of 3 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 0.0%
Details

@SafwatHalaby SafwatHalaby deleted the SafwatHalaby:lean branch May 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment