New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually empty the open list #1952

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
3 participants
@worktycho
Member

worktycho commented May 6, 2015

No description provided.

@@ -245,7 +245,7 @@ void cPath::FinishCalculation()
}
m_Map.clear();
m_OpenList.empty();
m_OpenList = std::priority_queue<cPathCell *, std::vector<cPathCell *>, compareHeuristics>{};

This comment has been minimized.

@SafwatHalaby

SafwatHalaby May 6, 2015

Member

Isn't it supposed to be ( )?

@SafwatHalaby

SafwatHalaby May 6, 2015

Member

Isn't it supposed to be ( )?

This comment has been minimized.

@worktycho

worktycho May 6, 2015

Member

its a new c++11 syntax. It avoids issues with most vexing parse.

@worktycho

worktycho May 6, 2015

Member

its a new c++11 syntax. It avoids issues with most vexing parse.

This comment has been minimized.

@SafwatHalaby

SafwatHalaby May 6, 2015

Member

Oh, thanks.

@SafwatHalaby

SafwatHalaby May 6, 2015

Member

Oh, thanks.

@SafwatHalaby

This comment has been minimized.

Show comment
Hide comment
@SafwatHalaby

SafwatHalaby May 6, 2015

Member

I'd say it's pretty trivial yet important, and should be merged right away.

Member

SafwatHalaby commented May 6, 2015

I'd say it's pretty trivial yet important, and should be merged right away.

bearbin added a commit that referenced this pull request May 6, 2015

Merge pull request #1952 from mc-server/coverity-fix
Actually empty the open list

@bearbin bearbin merged commit 9544020 into master May 6, 2015

4 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 0.0%
Details

@tigerw tigerw deleted the coverity-fix branch May 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment