/cuberite

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved shared cmake flags to the CMAKE_C_FLAGS var #2173

Merged
merged 1 commit into from May 30, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@worktycho @bearbin @madmaxoft
@worktycho
Member

worktycho commented May 30, 2015

Fixes #2168

bearbin added a commit that referenced this pull request May 30, 2015

@bearbin
Merge pull request #2173 from mc-server/CleanCmake 
Moved shared cmake flags to the CMAKE_C_FLAGS var
Loading status checks…
ddb173b

@bearbin bearbin merged commit ddb173b into master May 30, 2015
3 checks passed

3 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bearbin bearbin deleted the CleanCmake branch May 30, 2015

@bearbin

This comment has been minimized.

Show comment
Hide comment
@bearbin

bearbin May 30, 2015

Member

Huh? GitHub showed all builds as successful when I merged, and now it shows appveyor as failed.
Member

bearbin commented May 30, 2015

Huh? GitHub showed all builds as successful when I merged, and now it shows appveyor as failed.
@madmaxoft

This comment has been minimized.

Show comment
Hide comment
@madmaxoft

madmaxoft May 31, 2015

Member

I quite remember this exact trick not working for some reason - of course I had tried this before.
Member

madmaxoft commented May 31, 2015

I quite remember this exact trick not working for some reason - of course I had tried this before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment