New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cgo #5

Merged
merged 5 commits into from Mar 28, 2017

Conversation

Projects
None yet
2 participants
@catatsuy
Contributor

catatsuy commented Mar 26, 2017

Go can call POSIX API without using cgo.

remove cgo
Go can call POSIX API without using cgo.
"unsafe"
"golang.org/x/sys/unix"

This comment has been minimized.

@cubicdaiya

cubicdaiya Mar 28, 2017

Owner

Put this into glide.yaml and glide.lock.

@cubicdaiya

cubicdaiya Mar 28, 2017

Owner

Put this into glide.yaml and glide.lock.

This comment has been minimized.

@catatsuy

catatsuy Mar 28, 2017

Contributor

I added glide.yaml and glide.lock

@catatsuy

catatsuy Mar 28, 2017

Contributor

I added glide.yaml and glide.lock

@cubicdaiya

This comment has been minimized.

Show comment
Hide comment
@cubicdaiya

cubicdaiya Mar 28, 2017

Owner

@catatsuy Fix compilation error.

$ make
GO15VENDOREXPERIMENT=1 go build  -o bin/cachectl cmd/cachectl/cachectl.go
# github.com/cubicdaiya/cachectl/cachectl
cachectl/activepages.go:24: cannot use nil as type int in return argument
cachectl/activepages.go:42: cannot use nil as type int in return argument
cachectl/purge.go:26: no new variables on left side of :=
cachectl/purge.go:28: invalid operation: fsize * rate (mismatched types int64 and float64)
cachectl/stat.go:21: undefined: log.Errorf
make: *** [bin/cachectl] Error 2
Owner

cubicdaiya commented Mar 28, 2017

@catatsuy Fix compilation error.

$ make
GO15VENDOREXPERIMENT=1 go build  -o bin/cachectl cmd/cachectl/cachectl.go
# github.com/cubicdaiya/cachectl/cachectl
cachectl/activepages.go:24: cannot use nil as type int in return argument
cachectl/activepages.go:42: cannot use nil as type int in return argument
cachectl/purge.go:26: no new variables on left side of :=
cachectl/purge.go:28: invalid operation: fsize * rate (mismatched types int64 and float64)
cachectl/stat.go:21: undefined: log.Errorf
make: *** [bin/cachectl] Error 2
Show outdated Hide outdated cachectl/stat.go Outdated
Show outdated Hide outdated cachectl/activepages.go Outdated
Show outdated Hide outdated cachectl/activepages.go Outdated

@cubicdaiya cubicdaiya added the LGTM label Mar 28, 2017

@cubicdaiya cubicdaiya merged commit 275dfba into cubicdaiya:master Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment