Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : String extraction does not work on Windows host #2426

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@in2etv
Copy link
Contributor

commented Aug 4, 2018

Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html

What I have added/changed is:

cuckoo/processing/strings.py

The goal of my change is:

Bugfix for Windows host : #2425

What I have tested about my change is:

String extraction of static analysis.
I tested it on both Windows guest and Linux guest.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 4, 2018

Codecov Report

Merging #2426 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2426      +/-   ##
=========================================
+ Coverage      62%     62%   +<.01%     
=========================================
  Files         152     152              
  Lines       15177   15179       +2     
=========================================
+ Hits         9410    9412       +2     
  Misses       5767    5767
Impacted Files Coverage Δ
cuckoo/processing/strings.py 92.59% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41c7c5...33fef13. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Aug 4, 2018

Coverage Status

Coverage decreased (-2.3%) to 59.668% when pulling 33fef13 on in2etv:patch_strings into c41c7c5 on cuckoosandbox:master.

@jbremer jbremer force-pushed the cuckoosandbox:master branch from 3b62838 to 9aa8bde Sep 19, 2018

@jbremer

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

This has been manually merged into the 2.0.7 release, thanks!

@jbremer jbremer closed this Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.