This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
block public file download #2738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been manually merged into the 2.0.7 release, thanks! |
Inndy
reviewed
Jan 14, 2020
|
|
||
| def get_client_ip(request): | ||
| try: | ||
| x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR') |
There was a problem hiding this comment.
X-Forwarded-For can be spoofed easily.
ref: https://portswigger.net/kb/issues/00400110_spoofable-client-ip-address
There was a problem hiding this comment.
Very true, this part was edited out and merged manually after that, without that header. 🙂
https://github.com/cuckoosandbox/cuckoo/blob/master/cuckoo/web/web/middle.py#L36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have added/changed is: Create middleware that blocks file download if ipv4 or ipv6 address not in allowed subnets/ip list.
The goal of my change is: To block public download of malware samples and dropped files so only admins can download and users can't download other users' files. Not to allow users to use Cuckoo to distribute malware.
What I have tested about my change is: file download works if in list or no list in local settings, file download blocked if not in list.