Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misp config and whitelist #2741

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@amadisson
Copy link
Contributor

commented May 24, 2019

What I have added/changed is:

For reporting to Misp added more configurable parameters (min_malscore, distribution, analysis, threat_level, tag, upload_sample).
Added MISP domain, ip, urls, hash whitelists.
Changed signatures comments to get info from signatures marks.
Misp category from Sandbox detection to External analysis because no Sandbox detection category in latest Misp (2.4.107).

The goal of my change is:

Automate Misp publishing and avoid false positives.

What I have tested about my change is:

Tested that Misp event not created always when min_malscore configured-
Sample uploaded when upload_sample yes-
Configured distribution, analysis, threat_level, tag appear in Misp-
Signatures comments have actual info inside "()", not emtpy always-
External analysis and Network analysis attributes created.

@SteveClement

This comment has been minimized.

Copy link

commented Jun 4, 2019

Looks interesting, anyone tested it yet?

@RicoVZ

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@SteveClement
Yep 🙂
We are however changing the code a little. But this feature will be included in the next release.

@jbremer

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

This has been merged into the 2.0.7 release, thanks!

@jbremer jbremer closed this Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.