Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

At runtime, Aruba only needs rspec-expectations #120

Merged
merged 1 commit into from

4 participants

@mvz

Makes full rspec only a development dependency, while keeping rspec-expectations as a runtime dependency.

A first step for #119.

@aslakhellesoy

You want us to pull this? The library still uses rspec for assertions (search for should) and this breaks it by making rspec a dev dependency.

@mvz
mvz commented

That's why rspec-expectations remains as a runtime dependency. That's where rspec defines should and friends.

@jarl-dk
Collaborator

Seems like a valid, though subtle, PR to me... A gem shouldn't require more than is actually used.

@mattwynne mattwynne merged commit 408f8fb into cucumber:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 30, 2012
  1. @mvz
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  aruba.gemspec
View
3  aruba.gemspec
@@ -12,10 +12,11 @@ Gem::Specification.new do |s|
s.add_runtime_dependency 'cucumber', '>= 1.1.1'
s.add_runtime_dependency 'childprocess', '>= 0.2.3'
s.add_runtime_dependency 'ffi', '>= 1.0.11'
- s.add_runtime_dependency 'rspec', '>= 2.7.0'
+ s.add_runtime_dependency 'rspec-expectations', '>= 2.7.0'
s.add_development_dependency 'bcat', '>= 0.6.1'
s.add_development_dependency 'rdiscount', '>= 1.6.8'
s.add_development_dependency 'rake', '>= 0.9.2'
+ s.add_development_dependency 'rspec', '>= 2.7.0'
s.rubygems_version = ">= 1.6.1"
s.files = `git ls-files`.split("\n")
Something went wrong with that request. Please try again.