At runtime, Aruba only needs rspec-expectations #120

Merged
merged 1 commit into from Oct 9, 2012

4 participants

@mvz

Makes full rspec only a development dependency, while keeping rspec-expectations as a runtime dependency.

A first step for #119.

@aslakhellesoy
Cucumber member

You want us to pull this? The library still uses rspec for assertions (search for should) and this breaks it by making rspec a dev dependency.

@mvz
mvz commented Jul 1, 2012

That's why rspec-expectations remains as a runtime dependency. That's where rspec defines should and friends.

@jarl-dk
Cucumber member

Seems like a valid, though subtle, PR to me... A gem shouldn't require more than is actually used.

@mattwynne mattwynne merged commit 408f8fb into cucumber:master Oct 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment