Skip to content

i18n #34

Closed
jbpros opened this Issue Oct 29, 2011 · 7 comments

3 participants

@jbpros
Cucumber member
jbpros commented Oct 29, 2011

Add support for all Gherkin's spoken languages. The # language: xx comment directive should be recognized.

This will probably impact the undefined step definition snippets.

@Fodi69
Fodi69 commented Jul 24, 2012

I would be happy to see this feature implemented.

@jbpros
Cucumber member
jbpros commented Jul 24, 2012

Thanks to recent changes in Gherkin.js, this will be easier to implement. I moved it from the 0.5 milestone to 0.4.

@ldegen
ldegen commented Jan 13, 2014

hi everyone,
It seems we are almost there:

There was an encoding issue in gherkin, cucumber/gherkin#225, but that is fixed in 2.12.2.
I just had another look at #116, which I understand is based on #109.
I added a trivial modification to the regexp used to detect the language directive and rebased it on top of the current master of the original repository.

The result is here: ldegen/cucumber-js@0beabd4

As far as I can tell, it works as it should. In fact, we are using this right now on a real project with German scenarios, umlauts and all. No problems thus far.

I am not sure how to proceed now. Should I start another pull request?

There should probably be some scenarios in features/cucumber-tck/i18n.feature?

cheers,
--lu

@jbpros
Cucumber member
jbpros commented Jan 14, 2014

Thank you for this @ldegen.

Adding scenarios to the feature file and making them pass would indeed be the next step. Are you up for it? Please make another PR if you are.

@ldegen ldegen added a commit to ldegen/cucumber-tck that referenced this issue Feb 21, 2014
@ldegen ldegen Adding scenarios to i18n.feature
This is related to cucumber/cucumber-js#34.
Please note that this *will fail* with the current master
of cucumber/cucumber-js.
58606f0
@ldegen
ldegen commented Feb 21, 2014

@jbpros, today I found myself with some time on my hands so I tried to pull (pun intended) this of.

I am not sure, if this is what you had in mind. I made a separate pull request cucumber/cucumber-tck#15 to get the i18n scenarios into cucumber-tck, but of course those will fail for cucumber-js unless #156 is merged.
I would have prefered to put both in a single pull request, but I have no idea if this is even possible?

@ldegen
ldegen commented Feb 21, 2014

Ah, btw, the generation of snippets for undefined steps is still missing. So you probably do not want to close this issue yet.

@jbpros jbpros added a commit to cucumber/cucumber-tck that referenced this issue Mar 5, 2014
@ldegen ldegen Add i18n scenarios
This is related to cucumber/cucumber-js#34.
Please note that this *will fail* with the current master
of cucumber/cucumber-js.
05b4fbc
@jbpros jbpros added a commit that closed this issue Mar 5, 2014
@ldegen ldegen Add i18n support (close #156)
Also closes #34, closes #109 and closes #116.

Squashed commit of the following:

commit 8a6b2cfc6fbc32780dc94b17cb62285ee442bc8b
Author: Julien Biezemans <jb@jbpros.com>
Date:   Wed Mar 5 16:11:41 2014 +0100

    Bump TCK

commit 1a3c684d2d737d9dfff4cf6d95b923911f520ad0
Merge: 0beabd4 98a2725
Author: Julien Biezemans <jb@jbpros.com>
Date:   Wed Mar 5 16:05:11 2014 +0100

    Merge branch 'master' into i18n

commit 0beabd4
Author: Lukas Degener <l.degener@tarent.de>
Date:   Tue Sep 10 21:41:34 2013 +0200

    more flexible regexp for detecting language

commit b107286
Author: Brian Clozel <brian.clozel@gmail.com>
Date:   Wed Mar 20 18:26:40 2013 +0100

    update specs for i18n support

commit 6fa8f93
Author: Brian Clozel <brian.clozel@gmail.com>
Date:   Wed Mar 20 18:25:04 2013 +0100

    used a modified patch made by @vslinko - see #109
9ace841
@jbpros jbpros closed this in 9ace841 Mar 5, 2014
@jbpros
Cucumber member
jbpros commented Mar 5, 2014

@ldegen thank you for your great work on this. Your PR has been merged. Snippets are indeed not yet internationalised but that can be handled separately. The most important thing was to support other languages than english in Gherkin files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.