Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags example in Changelog of 2.0.0-rc.0 not correct #840

Closed
wswebcreation opened this issue May 28, 2017 · 3 comments
Closed

Tags example in Changelog of 2.0.0-rc.0 not correct #840

wswebcreation opened this issue May 28, 2017 · 3 comments

Comments

@wswebcreation
Copy link

@wswebcreation wswebcreation commented May 28, 2017

In the Changelog of 2.0.0-rc.0 the changes in the tags are explained. I see the example --tags @foo --tags @bar becomes --tags '@foo and bar' and according to what I understand this isn't correct. It should be --tags @foo --tags @bar becomes --tags '@foo and @bar', so an @ for bar.

I do see it correct in the hooks documentation.

What's the best way to fix this? Can I create a PR for the Changelog?

@charlierudolph

This comment has been minimized.

Copy link
Member

@charlierudolph charlierudolph commented Jun 1, 2017

Thanks for reporting this! I went ahead and fixed it since its so small.

@wswebcreation

This comment has been minimized.

Copy link
Author

@wswebcreation wswebcreation commented Jun 1, 2017

Tnx

@lock

This comment has been minimized.

Copy link

@lock lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.