Documentation and test for AfterFeatures event #171

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
1 participant
Contributor

eddieloeffen commented Apr 15, 2014

I spent ages doing the wrong setup for AfterFeatures to try and close my browser at the end of the tests, so I thought that including a test and better documentation might help other people.

This also fixes the unimplemented cli.feature step, and failing assert due to console coloring.

I had to apply the patch from comments in #120 to get these tests to run correctly.

eddieloeffen added some commits Apr 14, 2014

@eddieloeffen eddieloeffen Add a cucumber test that shows adding an AfterFeatures event listener…
… causes the exit code to always equal 0

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
9549a96
@eddieloeffen eddieloeffen Update cli.feature test for 'AfterFeatures' to use the correct "regis…
…terHandler" function. This makes the test pass correctly.

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
7855d6f
@eddieloeffen eddieloeffen Update README.md
Update documentation to include the AfterFeatures event, and add a mention to the other events available through the registerHandler function.
4eb49b7
@eddieloeffen eddieloeffen Remove an extra console.log in bin/cucumber.js that was causing the b…
…uild to fail.

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
a131c9f
@eddieloeffen eddieloeffen update cli.feature tests that were expecting "." instead of "F" for f…
…ailing tests.

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
e284b53
@eddieloeffen eddieloeffen Fix the cli step that checks expected output to use indexOf again, an…
…d correctly strip color codes and normalize new line characters before checking the two strings

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
9829c51
@eddieloeffen eddieloeffen Remove the check for "F" character in cli.feature tests, as the outpu…
…t contains a lot more stuff in between "F" and "1 scenario..."

Signed-off-by: Eddie Loeffen <eddieloeffen@gmail.com>
39b7167

jbpros closed this in ca9bea3 Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment