fix timeout to allow fake timers #562
Conversation
|
Maybe throw in a feature test that uses sinon.useFakeTimers or stubs out one of the methods? |
|
@charlierudolph Added feature tests. |
| Then it passes | ||
|
|
||
|
|
||
| Scenario: real time is restored |
There was a problem hiding this comment.
I'm not certain this is test is really needed. The name makes me think that real time was mocked but it never was.
There was a problem hiding this comment.
The point of this test is to show that after running the first scenario in a faked time context (note the @fakedTime tag), then the second scenario runs with real time restored (no @fakedTime tag).
There was a problem hiding this comment.
Yeah, but to cucumber-js real time was never faked. To me this is just testing that you correctly ran this.clock.restore() in your after hook. Not running that doesn't effect whether or not cucumber-js works.
|
Thanks @mjhm. Feature tests look great. Just a couple things to cleanup and this is good to go. |
|
Here you go @charlierudolph |
|
Ping @charlierudolph |
| this.After({tags: ['@fakedTime']}, function(scenario, callback) { | ||
| this.clock.restore(); | ||
| callback(); | ||
| }); |
There was a problem hiding this comment.
you can just omit the callback in each of these since they are synchronous. Thus you can omit scenario as well
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@charlierudolph This is the fix to allow
sinon.useFakeTimersor similar time mocking to work. #535I'm not sure exactly where to plug in new tests for it though.
I have my own example test repo at https://github.com/mjhm/cucumber-test which demonstrates the problem using 0.10.2 vs this update.