Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest groovy and cucumber jvm #47

Merged

Conversation

lsiu
Copy link
Contributor

@lsiu lsiu commented Apr 23, 2023

🤔 What's changed?

Upgrade to the latest groovy version 4.0.11 and cucumber-core version 7.11.2

⚡️ What's your motivation?

I would like to use cucumber-groovy-jvm with the latest cucumber-core

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

  • I don't know the historry to running the maven ant groovy-cli-test, I replaced it with the `org.junit.platform.console.ConsoleLauncher

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

renovate bot and others added 16 commits April 22, 2023 04:07
…entered (\d+) into .* calculator$/" is no longer required, as Gherkin will not compile duplicated steps like this
…engine`

remove duplicate versions that are already in root pom
…s-maven-surefire-plugin-3.x' into update-to-latest-groovy-and-cucumber-jvm
 * Use -bom projects to manage dependencies where possible
 * Replace JUnit 4 with JUnit 5
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, looked pretty good. I pushed some changes to help out.

Specifically:

  • Upgrading to Surefire v3 so we can use JUnit 5.
  • Using Bills of Material to keep all the dependencies aligned (and remove all the explicit version numbers everywhere)
  • Replacing JUnit 4 with JUnit 5.

Don't forget to add an entry to the CHANGELOG.md.

I don't know the historry to running the maven ant groovy-cli-test, I replaced it with the `org.junit.platform.console.ConsoleLauncher

Interesting question.

I get the impression that the groovy-cli-test is testing the cucumber-groovy-shaded.jar that is produced when building this project. It seems to be a way to run Cucumber Groovy in a standalone fashion.

If you think that currently there is no reason to provide a shaded jar, please do feel free to remove the code that creates the shaded jar along with the test for it. Since this project currently doesn't have a maintainer (#27) and I don't use Groovy on regular basis I'll defer to your judgement on this.

…longer supported, because it defaults to strict-mode. (See: cucumber/cucumber-jvm@5fbae84)
@lsiu
Copy link
Contributor Author

lsiu commented Apr 23, 2023

I put the groovy-cli-test back it. It just wraps the cli mechanism provided by cucumber-core. Doesn't look like too much work to support it for now.

@mpkorstanje mpkorstanje merged commit ada4138 into cucumber:main Apr 23, 2023
@aslakhellesoy
Copy link
Contributor

Hi @lsiu,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

@lsiu since you are one of the few people using cucumber-jvm-groovy, would you be interested in maintaining it?

@lsiu lsiu deleted the update-to-latest-groovy-and-cucumber-jvm branch April 24, 2023 14:39
@lsiu
Copy link
Contributor Author

lsiu commented Apr 24, 2023

@mpkorstanje , I will do what I can.
To be honest, I started with cucumber-jvm-groovy in my previous job. Finally, got around to introduce this in my new job, but found out cucumber-jvm-groovy is no longer maintained. Tried cucumber-jvm-java8 and learned it is getting deprecated, so I went with cucumber-jvm-java. IMHO, the duplicate step text in annotation and method name is still not idea, so I am trying to give cucumber-jvm-groovy a kick.

@mpkorstanje
Copy link
Contributor

Mmh. Cucumber-Java 8 hasn't been deprecated yet. And I'm planning to have a replacement ready when that happens.

If you want you could help out with the replacement instead. But I'll leave that up to your interests:

cucumber/cucumber-jvm#2542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants