From 1e85c8dab3aedd9b613dfe4488739b3488e8ce74 Mon Sep 17 00:00:00 2001 From: "M.P. Korstanje" Date: Sun, 27 Nov 2022 19:51:41 +0100 Subject: [PATCH] [Core] Mark Allure 5 and 6 plugins as incompatible This bans the use of the incompatible plugins ``` io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm ``` This will prevent users from making the mistake of using the wrong plugin version with Cucumber. This avoids questions and noise all around. --- CHANGELOG.md | 2 ++ .../src/main/java/io/cucumber/core/options/PluginOption.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d479f59945..3f03033c1d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Enabled reproducible builds ([2641](https://github.com/cucumber/cucumber-jvm/issues/2641) Hervé Boutemy ) +- [Core] Mark Allure 5 and 6 plugins as incompatible ([2652](https://github.com/cucumber/cucumber-jvm/issues/2652) M.P. Korstanje) + ## [7.9.0] - 2022-11-01 ### Changed diff --git a/cucumber-core/src/main/java/io/cucumber/core/options/PluginOption.java b/cucumber-core/src/main/java/io/cucumber/core/options/PluginOption.java index ece0aac7bd..ace7d0134d 100644 --- a/cucumber-core/src/main/java/io/cucumber/core/options/PluginOption.java +++ b/cucumber-core/src/main/java/io/cucumber/core/options/PluginOption.java @@ -79,6 +79,8 @@ public class PluginOption implements Options.Plugin { incompatible.add("io.qameta.allure.cucumber2jvm.AllureCucumber2Jvm"); incompatible.add("io.qameta.allure.cucumber3jvm.AllureCucumber3Jvm"); incompatible.add("io.qameta.allure.cucumber4jvm.AllureCucumber4Jvm"); + incompatible.add("io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm"); + incompatible.add("io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm"); INCOMPATIBLE_PLUGIN_CLASSES = unmodifiableSet(incompatible); }