Permalink
Commits on Sep 13, 2018
  1. [Weld] Increase coverage of WeldFactory (#1459)

    nhojpatrick authored and mpkorstanje committed Sep 13, 2018
    [Weld] Increase coverage of WeldFactory
Commits on Sep 9, 2018
  1. [Build] Do not remove cached cucumber artifacts

    mpkorstanje committed Sep 9, 2018
    There is no need to remove cached artifacts. Maven rebuilds from source each time.
    
    And it slows down the semantic version check which uses our older released artifacts.
  2. Update urls in readme

    mpkorstanje committed Sep 9, 2018
  3. [Core] Support quoted strings in cucumber.options (#1453)

    nhojpatrick authored and mpkorstanje committed Sep 9, 2018
    Shellwords takes the program arguments from cucumber.options and splits them into separate strings but still groups words bound by " or '
Commits on Sep 6, 2018
  1. Add ConcurrentEventListener to Plugin Doc

    mpkorstanje
    mpkorstanje committed Sep 6, 2018
Commits on Sep 1, 2018
  1. Update spring documentation (#1441)

    mpkorstanje committed Sep 1, 2018
    Rewrote a part of the spring readme for clarity.
    
    Removed the reference to `@scope("cucumber-glue")`. The existence of `"cucumber-glue"` is an implementation detail. Users should rely on the mechanisms provided by Spring i.e: `@DirtiesContext`.
    
    Added an section on how to connect the Spring configuration to Cucumber step definitions.
  2. [JUnit,TestNG] Update documentation (#1442)

    mpkorstanje committed Sep 1, 2018
    Document how to enable parallel execution for JUnit and TestNG
Commits on Aug 29, 2018
  1. [Core] Use fully classified DataTable in snippet (#1399)

    mlvandijk authored and mpkorstanje committed Aug 28, 2018
    Fixes #1433
Commits on Aug 28, 2018
  1. [Core] Restrict StepDefAnnotation to Annotations

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
    Fixes #1437
  2. Add details of #1414 to changelog

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
  3. Update changelog wrt. 1408

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
  4. Add details of #1414 to changelog

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
  5. Remove android reference from release guide

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
  6. Bump dependencies

    mpkorstanje
    mpkorstanje committed Aug 28, 2018
Commits on Aug 27, 2018
  1. [Core] Hide runner implementation details (#1440)

    mpkorstanje committed Aug 27, 2018
    Hide some of the runners implementation details
    
    Without internal dependencies the object graph of a runner looks like this:
    
    ```
    Runner
          |--> Backend  
                    |--> Glue
                          |--> StepDefinition
                          |--> HookDefinition
          |--> EventBus 
    ```
    
    As such only the runner, event bus and backend implementations need to be accessible outside of the runner package. By moving all internal dependencies into the runner package,  making all internal classes package private we ensure that the implementation details of the runner don't leak. By making all internal classes final we ensure that all mocks are external parts of the runner improving the fidelity of the tests.
    
    Eventually the whole of `cucumber-jvm` should use an inside out approach to constructing the object graph. Hiding all implementation details is an important first step in this.
Commits on Aug 26, 2018
  1. Update changelog wrt. 1430 and 1439

    mpkorstanje
    mpkorstanje committed Aug 26, 2018
Commits on Aug 25, 2018
  1. [Core] Set scenario result as step finishes (#1430)

    mpkorstanje committed Aug 25, 2018
    * Clean up pom
    
    * Update scenario result when step finishes
    
    The results of a step were set on the scenario after a test step
    finished. This meant that the result of the step was not available in
    its after hooks.
    
    By adding the result of the step to the scenario in TestStep we ensure
    that scenario always contains the most recent result. This removes the
    need to pass the scenario results around.
    
    Additionally:
    
     * Scenario has moved from cucumber.runtime.ScenarioImpl to
     cucumber.runner.Scenario and made package private. This prevents the
     implementation being used outside of the API. Users of
     ScenarioImpl.getError should use an event listener to create their
     reports.
    
     * TestStep.run no longer requires a language parameter. With Gherkin v5
     the language is not used anywhere.
  2. [Core] Added extraGlue option to @CucumberOptions (#1439)

    ekalin authored and mpkorstanje committed Aug 25, 2018
    This option works similarly to glue, specifing packages in which to
    search for steps and hooks, but the default search path (the
    current package) is included in the list of glue packages, whereas
    glue includes only the explicitly listed packages.
    
    Closes #1438.
Commits on Aug 21, 2018
  1. Update changelog w.r.t #1389

    mpkorstanje
    mpkorstanje committed Jul 10, 2018
Commits on Aug 7, 2018
Commits on Jul 27, 2018
  1. Update changelog

    mpkorstanje committed Jul 27, 2018
  2. [Core] Deprecate Formatter interface (#1407)

    mlvandijk authored and mpkorstanje committed Jul 27, 2018
    Fixes: #1401, #1408,
  3. Fix build

    mpkorstanje committed Jul 27, 2018
  4. [Core] Upgrade datatable to 1.1.3

    lsuski authored and mpkorstanje committed Jul 27, 2018
    Squashed commit of the following:
    
    commit 06ced5a2681b5971239e0db314844bc69224baec
    Author: M.P. Korstanje <rien.korstanje@gmail.com>
    Date:   Fri Jul 27 13:50:14 2018 +0200
    
        Upgrade datatable to 1.1.3
    
    commit 8dfbd90
    Author: lukasz.suski <szakal783@wp.pl>
    Date:   Fri Jul 6 17:10:29 2018 +0200
    
        Add ability to register default transformers for table cell and entry
Commits on Jul 6, 2018
  1. [Core] Support parallel execution of pickles (#1389)

    boaty82 authored and mpkorstanje committed Jul 6, 2018
    Adds supports for parallel execution of pickles to cucumber-jvm
    
    # Added --threads argument to runtime options
    
    Allows users of the CLI to specify the (max) number of threads to be used to run the tests. TestNG/JUnit users should consult their documentation on how to run JUnit/TestNG in parallel.
    
    Note that JUnit will only run features in parallel, not scenarios.
    
    # Concurrent Events
    
    During parallel executing events from the execution of different pickles may interleave. To avoid breaking existing Formatters, these will now receive all test events after the run is complete. Because we are unable to infer whether JUnit/TestNG run in parallel the assumption is that they are and their formatter will always get all events after the run. 
    
    Formatters that can handle concurrent events can events in real time by implementing the ConcurrentEventListener.
    
    # New formatter introduced TimelineFormatter
    
    Which produces reports using vsjis.org timeline to highlight which feature was run on which Thread and when.
  2. Android extract to separate project (#1411)

    aslakhellesoy committed Jul 6, 2018
    * Extract Android to separate project
    
    * Move Travis config for Android
Commits on Jun 29, 2018
  1. Remove unused dependencies from pom

    mpkorstanje
    mpkorstanje committed Jun 29, 2018
  2. Remove OSGi

    aslakhellesoy authored and mpkorstanje committed Jun 29, 2018
    [OSGi] Remove OSGi