Add support for monochrome pretty format #221

Closed
jharmn opened this Issue Feb 24, 2012 · 5 comments

Comments

Projects
None yet
4 participants
@jharmn

jharmn commented Feb 24, 2012

Further details were posted in the Cukes group. The basic gist is that the cucumber.monochrome system property has apparently been removed, so there is no other means to eliminate color formatting in pretty output at the moment.
http://groups.google.com/group/cukes/browse_thread/thread/5e87794784d9797b

@klausbayrhammer

This comment has been minimized.

Show comment Hide comment
@klausbayrhammer

klausbayrhammer Feb 27, 2012

Contributor

The desired behavior would be to have color formatting by default and disable it using a system property cucumber.monochrome=true?

Contributor

klausbayrhammer commented Feb 27, 2012

The desired behavior would be to have color formatting by default and disable it using a system property cucumber.monochrome=true?

@jharmn

This comment has been minimized.

Show comment Hide comment
@jharmn

jharmn Feb 27, 2012

Exactly. The color pretty print is perfect for normal interactive BDD (devs, qa, POs, etc) use, but in certain situations (such as CI/CD deployments in Jenkins/Go/etc), the monochrome output is preferrable.

jharmn commented Feb 27, 2012

Exactly. The color pretty print is perfect for normal interactive BDD (devs, qa, POs, etc) use, but in certain situations (such as CI/CD deployments in Jenkins/Go/etc), the monochrome output is preferrable.

@hutchy2570

This comment has been minimized.

Show comment Hide comment
@hutchy2570

hutchy2570 Feb 29, 2012

Contributor

I have added support for this flag in my branch SHA: d37bdf6

If this is the kind of thing you're looking for I'll create a pull request.

Contributor

hutchy2570 commented Feb 29, 2012

I have added support for this flag in my branch SHA: d37bdf6

If this is the kind of thing you're looking for I'll create a pull request.

@jharmn

This comment has been minimized.

Show comment Hide comment
@jharmn

jharmn Feb 29, 2012

Looks to be precisely what I was looking for, and seems to address the prior "TODO". Thanks!

jharmn commented Feb 29, 2012

Looks to be precisely what I was looking for, and seems to address the prior "TODO". Thanks!

hutchy2570 pushed a commit to lgi-kitd/cucumber-jvm that referenced this issue Mar 1, 2012

Michael Hutchinson Michael Hutchinson
Fixed #232 & #221
Updated JUnitFormatter to use Appendable.
Updated FormatterFactory to wrap File in FileWriter
Updated FormatterFactory to create directories required for files
Updated FormatterFactory to add cucumber.monochrome flag to be passed to the Pretty & Progress formatters
@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Mar 28, 2012

Owner

This was fixed in 1.0.0

Owner

aslakhellesoy commented Mar 28, 2012

This was fixed in 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment