Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

JsonFormatter and JsonPrettyFormatter require Appendable, FormatterFactory uses File #232

Closed
hutchy2570 opened this Issue · 2 comments

2 participants

@hutchy2570

RC20 uses Gherkin java 2.9.0 which contains JsonFormatter and JsonPrettyFormatter classes which only have a constructor with a single Appendable arg.

The FormatterFactory tries, if the out arg is a File, to construct these with a File arg and results in java.lang.NoSuchMethodException: gherkin.formatter.JSONPrettyFormatter.(java.io.File).

Previously if the out arg was a File, it would be wrapped in a FileWriter in the FormatterFactory before constructing the Formatter.

@aslakhellesoy

I'll be fixing this when I attack #160, #142 and #148 - it's long overdue!

@aslakhellesoy aslakhellesoy was assigned
@hutchy2570 hutchy2570 referenced this issue from a commit in lgi-kitd/cucumber-jvm
Michael Hutchinson Fixed #232 & #221
Updated JUnitFormatter to use Appendable.
Updated FormatterFactory to wrap File in FileWriter
Updated FormatterFactory to create directories required for files
Updated FormatterFactory to add cucumber.monochrome flag to be passed to the Pretty & Progress formatters
89281a3
@aslakhellesoy

This was fixed in 1.0.0.RC24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.