Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

@txn should have a default @Order #398

Closed
mmalmeida opened this Issue · 5 comments

2 participants

@mmalmeida

the @txn hook is added if you define cucumber.runtime.java.spring.hooks in your hook.

However, with the current implementation you cannot seem to add any other @before hook that runs before that one.

Suggestion: Add a default @Order(10) to that hook, so we can add before hooks before that one.

@aslakhellesoy

I need to refresh my memory and read through #46 again. It's from before I started maintaining a proper History.md

@mmalmeida

Sure.If you want any help with it let me know. If you think this is something worth doing I can take care of this ticket.

@aslakhellesoy

Allright, I think this makes sense. Let's make it a higher number - 10 seems arbitrailiy low. How about 1000?

@mmalmeida

I think 1000 might be too high if we want to have hooks before and after this one - you'll need to give a number higher than 1000 to the ones ran after this one. Maybe 100 would suffice? I'm not sure there are many use cases where one would have 100 other hooks (and even then, you can repeat order numbers).

@aslakhellesoy
@aslakhellesoy aslakhellesoy closed this issue from a commit
@aslakhellesoy aslakhellesoy Set a default order of 100 for Spring @txn hooks in the cucumber.runt…
…ime.java.spring.hooks glue package. Closes #398.
c939c25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.