Skip to content

Clojure backend should define HookDefinition.getLocation(boolean detail) #461

Closed
aslakhellesoy opened this Issue Feb 13, 2013 · 8 comments

3 participants

@aslakhellesoy
Cucumber member

In ba049aa I had to disable the build of the Clojure module. Can someone with more clojure-fu than me make it build please? /cc @nilswloka @rplevy-draker @duck1123 @mva @hiredman

@aslakhellesoy
Cucumber member

Clojure will not be in the next release unless someone helps me fix this. /cc @nilswloka @rplevy-draker @duck1123 @mva @hiredman

BTW, sould any of you like to be the maintainer of the Clojure module so I have someone to assign tickets to?

@nilswloka
Cucumber member

What's the timeframe for fixing this? If next weekend is soon enough, you can assign the ticket to me. What amount of time would I have to invest to become the Clojure module's maintainer?

@duck1123
duck1123 commented Mar 4, 2013

I spent a little bit of time looking into this a while back when this ticket was first opened. Whatever is going on here, it's not a straight-forward error. I'll take another look and see if I can figure it out as well.

I'd hate to see the Clojure module be dropped.

@nilswloka
Cucumber member

I just added the missing method definition locally. Clojure module build is now working for me, but I want to wait for the Travis CI run as for some reason, the Rhino module build fails on my machine. If everything is green, I'll submit a pull request.

@aslakhellesoy
Cucumber member

@nilswloka wrote:

What amount of time would I have to invest to become the Clojure module's maintainer?

Not much. If you look in History.md you'll see that Clojure tickets are relatively rare. I'd say no more than a ticket per month, more likely one per two/three months.

And I see you already fixed it in #471 :-)

I have added you as a committer so I can assign those relatively rare tickets to you tickets hang around for a while without being fixed by others. If you don't have time, just let me know.

@nilswloka nilswloka was assigned Mar 5, 2013
@nilswloka
Cucumber member

Once a month certainly won't hurt. And it's good for my Clojure fu, too :) Glad to be of help.

@nilswloka nilswloka closed this Mar 5, 2013
@aslakhellesoy
Cucumber member

Awesome. Can you update History.md please?

@nilswloka nilswloka added a commit that referenced this issue Mar 6, 2013
@nilswloka nilswloka Update History.md
Add #461 and #471 to solved issues.
92b8d4e
@nilswloka
Cucumber member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.