Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Duplicate class in 1.1.3 release cucumber.api.DataTable #518

Closed
pranasblk opened this Issue May 13, 2013 · 5 comments

Comments

Projects
None yet
3 participants

Duplicate java class in 1.1.3 release cucumber.api.DataTable
It is deployed as cucumber-core and cucumber-groovy in 1.1.3

Owner

aslakhellesoy commented May 13, 2013

This is because we use the maven shade plugin to include the cucumber-core classes (and other jar dependencies) in the cucumber-groovy jar. Perhaps we should stop doing that.

Member

ffbit commented May 15, 2013

@pranasblk Could you provide more details about the problem, please?

Update: please ignore the rest of the comment.

I've tried to do a quick investigation with the following steps:

  • checked out the v1.1.3 tag
  • built the cucumber-groovy artifact, which lays in the groovy folder
  • opened the cucumber-groovy cucumber-groovy-1.1.3.jar in midnight commander
  • walked to the cucumber.api package
  • and got the following list of compiled classes

screen shot 2013-05-15 at 21 04 34

Also I've downloaded cucumber-groovy-1.1.3.jar from Maven Central, looked inside it and got the same compiled classes list.

Looking forward to your details.
Thanks in advance.

I believe what is in the build same goes to the maven central repository, but real issue is duplicate classes in different archives in the same Cucumber-JVM release.
screenshot

Owner

aslakhellesoy commented May 15, 2013

Why are you still discussing this? I said it's because of the shade plugin.

Owner

aslakhellesoy commented Jun 8, 2013

Closing this - fixed by #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment