Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring] Limit context configuration to a single class #1246

Merged
merged 2 commits into from Mar 9, 2018
Merged

[Spring] Limit context configuration to a single class #1246

merged 2 commits into from Mar 9, 2018

Conversation

mpkorstanje
Copy link
Contributor

Summary

Fixes #1240

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mpkorstanje mpkorstanje changed the title Limit spring context configuration to a single class [Spring ]Limit context configuration to a single class Oct 11, 2017
@mpkorstanje mpkorstanje changed the title [Spring ]Limit context configuration to a single class [Spring] Limit context configuration to a single class Oct 11, 2017
@mpkorstanje
Copy link
Contributor Author

Documentation can be updated after #1245 is merged

@mpkorstanje mpkorstanje added this to the 3.0.0 milestone Oct 11, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+25.7%) to 81.247% when pulling 10a32f5 on spring-limit-context-configuration-to-one into fdee635 on master.

@brasmusson brasmusson mentioned this pull request Oct 15, 2017
Merged
6 tasks
@stale
Copy link

stale bot commented Feb 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018
@stale
Copy link

stale bot commented Feb 19, 2018

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this Feb 19, 2018
@mpkorstanje mpkorstanje reopened this Feb 19, 2018
@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 19, 2018
@mpkorstanje mpkorstanje added the 🧷 pinned Tells Stalebot not to close this issue label Feb 19, 2018
@mpkorstanje
Limit spring context configuration to a single class
1c97048 
Fixes #1240
@mpkorstanje
Update spring examples to use single context configuration
c1bf598 
Cucumber picks up on spring context configurations by scanning for
glue code. Glue code is recognized by having a hook or step definition.
So the CucumberContextConfiguration must implement an empty hook or
step.
@mpkorstanje mpkorstanje force-pushed the spring-limit-context-configuration-to-one branch from 10a32f5 to c1bf598 Compare March 9, 2018 19:55
@mpkorstanje mpkorstanje merged commit 7e3182e into master Mar 9, 2018
@mpkorstanje mpkorstanje deleted the spring-limit-context-configuration-to-one branch March 9, 2018 19:55
@lock
Copy link

lock bot commented Mar 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🧷 pinned Tells Stalebot not to close this issue
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[Spring, Kotlin] Kotlin Metadata annotations breaks SpringFactory
3 participants
@mpkorstanje @coveralls @mlvandijk