Make Clojure DSL syntax cleaner (rewritten as modification of new back-end) #267

Merged
merged 1 commit into from Mar 20, 2012

Projects

None yet

3 participants

Contributor

No description provided.

Contributor

This replaces #248, so I closed that one.

Member

You probably want to change the template function for the reified Snippet in clojure-snippet (https://github.com/cucumber/cucumber-jvm/blob/master/clojure/src/main/clj/cucumber/runtime/clj.clj#L22) to reflect the new syntax.

Contributor

Hmm, good catch. So this is where it suggests a definition for a missing feature...

Owner

I moved the old to ClojureSnippet class from main to test in https://github.com/cucumber/cucumber-jvm/blob/master/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java

Now its only purpose is to test snippets, and we must manually make sure the snippet templates are in sync. That's fine.

I'll go ahead and change it.

Contributor

I actually wrote it earlier, but there was an internet outage, so I went out to enjoy the nice weather. I'll make it work with this change right now.

Owner

Just about to push now :-)

Let me know if that's not right...

@aslakhellesoy aslakhellesoy added a commit that referenced this pull request Mar 20, 2012
@aslakhellesoy aslakhellesoy Attribution. Closes #244, #267 0b0b02c
@aslakhellesoy aslakhellesoy merged commit f48aa96 into cucumber:master Mar 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment