Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Following the discussion of Getting knowledge about the current Locale within any custom @DefaultParameterTransformer I think this is the best solution to propose. It simply adds a getter-method to the current language value for
Scenario(and necessarily forTestCaseandTestCaseState). Doing so, any glue code class can provide a simple@Beforemethod including aScenarioargument, and by this get access to the current language. In result, any transformer method (either@DefaultParameterTransformer,@DefaultDataTableEntryTransformer,@DefaultDataTableCellTransformer) or type method (@ParameterType,@DataTableType) can provide locale-aware behaviour. (An example is given within this comment.)⚡️ What's your motivation?
See issue "Getting knowledge about the current Locale within any custom @DefaultParameterTransformer" (cucumber/cucumber-expressions#376).
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Please let me know, if you want me to add some documentation into section "Default Transformers" and/or section "Parameter Type" giving an example of a locale-aware type transform.
📋 Checklist: