Changing getPath to use path #342

Merged
merged 2 commits into from Jun 18, 2012

Conversation

Projects
None yet
2 participants
@mattharr
Contributor

mattharr commented Jun 12, 2012

This is my first go at contributing, so apologies for any mistakes.

As per #337 I've changed FileResource to use getPath rather than getAbsolutePath.

Let me know if I missed anything.

Thanks,

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Jun 13, 2012

A general comment: These tests assume Windows. Can you change \\ to Path.separator please?

A general comment: These tests assume Windows. Can you change \\ to Path.separator please?

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Jun 13, 2012

Really? I would expect the result to be just test.feature. Did this test pass for you?

Really? I would expect the result to be just test.feature. Did this test pass for you?

@mattharr

This comment has been minimized.

Show comment Hide comment
@mattharr

mattharr Jun 13, 2012

Contributor

Thanks for the comments. You're right the test didn't pass - I thought I'd run it OK, but maybe I fiddled with it after. Anyway, all cleared up now, and hopefully all the windows assumptions fixed.

Contributor

mattharr commented Jun 13, 2012

Thanks for the comments. You're right the test didn't pass - I thought I'd run it OK, but maybe I fiddled with it after. Anyway, all cleared up now, and hopefully all the windows assumptions fixed.

aslakhellesoy added a commit that referenced this pull request Jun 18, 2012

@aslakhellesoy aslakhellesoy merged commit 065e7e2 into cucumber:master Jun 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment