Spring Data JPA based repositories. #422

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

ffbit commented Nov 11, 2012

Hello!

Could you consider introduction of Spring Data - JPA based CRUD repositories to the spring-txn example project? It can help avoid writing some redundant code.

Thanks.
Have a great day.

Owner

aslakhellesoy commented Nov 12, 2012

Thanks a lot for your contribution! You clearly know more Spring than I do :-)

While I have you here - would you be interested in helping porting the spring-txn example to be a direct port of the AJAX example in the Cucumber book? (If so, I'll get you a copy if you don't have it).

I have been experimenting with this on a branch called spring-ajax, and the main problem I'm facing is to have a shared database transaction between the Cucumber Step Definitions and the Spring app. If I can get this to work it would be easier to clean the database with a rollback in an After. I thought I'd ask someone who's more intimate with Spring to help me.

/cc @paoloambrosio who wrote the original code my spring-ajax branch is based on.

Member

ffbit commented Nov 12, 2012

Hello!

I'm glad to hear that.
Please send me a copy (or just a piece with the example) of that famous book and I'll do my best.
My email can be gotten from my commit.

Thanks in advance.
Have a nice day.

Member

paoloambrosio commented Nov 12, 2012

I totally missed the spring-ajax branch!

I have done a few changes since I gave you the code (use mysql for production and hsql for test, introduced page objects, switchable js/non-js browser). Feel free to take a look: https://bitbucket.org/paoloambrosio/web-java/src (it was a private repository, so no licensing info, references to the book, etc.)

Member

ffbit commented Nov 12, 2012

@paoloambrosio, I forked your repository on bitbucket. I'll take a look in a couple of days.

Thanks.

Member

ffbit commented Nov 22, 2012

Hello,

There will be a local Ukrainian Hackathon [RU] in Kiyv.
And I've bought tickets on that event, but I haven't got a idea for the project.

So I think, why do not port the spring-txn example to a direct port of the AJAX example from the Cucumber book?
What do you think of that?

Thanks in advance.
Have a nice day.

Member

ffbit commented Nov 23, 2012

I've made a research on MVC testing support in Spring 3.1
According to obtained information, there is no way to test Spring shared transactions and AJAX with testing tools, like Selenium, because Servlet Container in this situation is a black box for us.

So I can implement required functionality without shared transactions.
Is this OK?

Member

ffbit commented Dec 7, 2012

I made the Chapter 14 of the Cucumber Book pull request.
Could you take a look at it, please

Owner

aslakhellesoy commented Jan 13, 2013

Isn't this PR obsoleted by #438 now?

Member

ffbit commented Jan 13, 2013

Yes it is.
Can you accept it in order to make the #438 more granular?

Respectfully,
Dmytro

13.01.2013, 22:29, "Aslak Hellesøy" notifications@github.com:

Isn't this PR obsoleted by #438 now?


Reply to this email directly or view it on GitHub.

Owner

aslakhellesoy commented Jan 13, 2013

I'm confused. You are saying this PR is obsoleted and you want me to accept it? (I assume you mean merge it in). That sounds contradictory to me.

Member

ffbit commented Jan 13, 2013

I'm sorry, I confused you.
The #438 consists of the #422 and another MVC code.
So, perhaps, it'll be nide to merge (accept) the #422 and make the #438 more granular.
That's my point.

Respectfully,
Dmytro

13.01.2013, 23:05, "Aslak Hellesøy" notifications@github.com:

I'm confused. You are saying this PR is obsoleted and you want me to accept it? (I assume you mean merge it in). That sounds contradictory to me.


Reply to this email directly or view it on GitHub.

Owner

aslakhellesoy commented Jan 13, 2013

Ok, closed it, but since the two PRs were diverging, #438 no longer applies cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment