Closes issue #448. Implementation based on SpringJunit4ClassRunner and still trying to stick to the previous behaviour as much as possible #489

Merged
merged 3 commits into from Apr 13, 2013

4 participants

@pasviegas

notes:

  • Removing tests as spec - http://goo.gl/315BS issue #448
  • Instances of test classes must respect convention (empty constructor), as in SpringJunit4ClassRunner.
@ffbit
Cucumber member

Thanks for your contribution - it could allow me to finish the #449 issue.

P.S.
In some companies' nets, like mine, links like http://goo.gl/whatever don't work.

@aslakhellesoy aslakhellesoy added a commit that referenced this pull request Apr 13, 2013
@aslakhellesoy aslakhellesoy Attribution. Closes #448, #489. 8eaab0a
@aslakhellesoy aslakhellesoy merged commit dc35d7b into cucumber:master Apr 13, 2013

1 check passed

Details default The Travis build passed
@aslakhellesoy
Cucumber member

Thanks a lot @pasviegas. Merged and pushed to master. It was hard to see what you had changed because the code was reformatted using different indentation settings. I have corrected this.

Details in DEVELOPERS.md

@pasviegas

Sorry for that, I will take more care next time ;)

@pfac

@pasviegas I apologize in advance for digging up an old commit but I'm wondering why "cucumber.xml" was removed from the resources list. Without this you have to annotate every step definitions class with @ContextConfiguration({"cucumber.xml"}) in order to be able to use @Autowired (it took me a while to find this out), at least with Spring 3.0. What's the recommended way to load the context now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment