Output embedded text in HTML report #501

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@tomdcc
Contributor
tomdcc commented Apr 8, 2013

The formatter in cucumber-html already supports embedding content
with mime-types starting with "text/" into the HTML report -
this just makes cucumber-jvm not swallow the text content before
it gets that far.

@tomdcc tomdcc Output embedded text in HTML report
The formatter in cucumber-html already supports embedding content
with mime-types starting with "text/" into the HTML report -
this just makes cucumber-jvm not swallow the text content before
it gets that far.
31f75a9
@aslakhellesoy
Member

LGTM!

@aslakhellesoy
Member

Now that I have thought about this, I actually think we should instead throw an exception in embed if the mimeType starts with "text/". The exception should contain a hint about using the write method instead.

WDYT?

@tomdcc
Contributor
tomdcc commented Apr 8, 2013

Oh yeah, I didn't even see the write method! Hmm. That works for my case, but I wonder if there's a broader case for being able to embed files of whatever type people want, and just linking to them rather than displaying them inline in the html? We might want to allow some sort of customisable filename or link text if we do that though... thoughts?

@tomdcc
Contributor
tomdcc commented Apr 8, 2013

So the idea would be that for video / images we could display inline, and anything else we'd just link to to allow someone to download it or whatever their browser wants to do with it.

@aslakhellesoy aslakhellesoy added a commit that closed this pull request Aug 15, 2013
@aslakhellesoy aslakhellesoy Attribution. Closes #501. 6e7e1b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment