Let the JUnitFormatter mark skipped tests as failures in strict mode #543

Merged
merged 1 commit into from Jun 13, 2013

Conversation

Projects
None yet
3 participants
@brasmusson
Contributor

brasmusson commented Jun 13, 2013

Let the option strict make the JUnitFormatter to mark skipped tests as failures.

Use a new interface StrictAware to determine which formatters the strict option should be passed to, following the example of the interface ColorAware determining which formatters the monochrome option is sent to.

JUnitFormatter marks skipped tests as failures in strict mode
Let the option strict make JUnitFormatter to mark skipped tests as
failures. Use a new interface StrictAware to determine which formatters
the strict option should be passed to, following the example of the
interface ColorAware determining which formatters the monochrome option
is sent to.
@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Jun 13, 2013

Owner

That was quick! I had to restart the travis build, but it looks good to me.

@lucas1000001 can you merge this one in?

Aslak

Owner

aslakhellesoy commented Jun 13, 2013

That was quick! I had to restart the travis build, but it looks good to me.

@lucas1000001 can you merge this one in?

Aslak

@ghost ghost assigned lucas-matt Jun 13, 2013

@lucas-matt

This comment has been minimized.

Show comment Hide comment
@lucas-matt

lucas-matt Jun 13, 2013

Contributor

Sure will do.

Contributor

lucas-matt commented Jun 13, 2013

Sure will do.

lucas-matt added a commit that referenced this pull request Jun 13, 2013

Merge pull request #543 from brasmusson/junit-formatter-strict
Let the JUnitFormatter mark skipped tests as failures in strict mode

@lucas-matt lucas-matt merged commit 9a6fe57 into cucumber:master Jun 13, 2013

1 check passed

default The Travis CI build passed
Details
@lucas-matt

This comment has been minimized.

Show comment Hide comment
@lucas-matt

lucas-matt Jun 13, 2013

Contributor

Built and tested fine locally - merged in.

Contributor

lucas-matt commented Jun 13, 2013

Built and tested fine locally - merged in.

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Jun 13, 2013

Owner

@lucas1000001 thanks - don't forget to update History.md

Owner

aslakhellesoy commented Jun 13, 2013

@lucas1000001 thanks - don't forget to update History.md

lucas-matt added a commit that referenced this pull request Jun 13, 2013

@lucas-matt

This comment has been minimized.

Show comment Hide comment
@lucas-matt

lucas-matt Jun 13, 2013

Contributor

Oops, sorry, done :)

Contributor

lucas-matt commented Jun 13, 2013

Oops, sorry, done :)

@brasmusson brasmusson deleted the brasmusson:junit-formatter-strict branch Jun 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment