Skip to content

Make the PrettyFormatter work by reverting to all-steps-first execution #557

Merged
merged 5 commits into from Jul 16, 2013

2 participants

@brasmusson

Resolve the mismatch between the PrettyFormatter in the Gherkin library and Cucumber-JVM, by reverting to the all-steps-first-execution which was used in Cucumber-JVM version 1.1.2.
This is safe since the JSONFormatter issues triggering the change to one-step-at-the-time execution in Cucumber-JVM version 1.1.3 (#426) has been resolved by https://github.com/cucumber/gherkin/pull/216 in Gherkin 2.12.0. The JSONFormatterTest added in #426 verifies this.

brasmusson added some commits Jun 1, 2013
@brasmusson brasmusson Make it possible to inject a glue when creating a Runtime
To aid testing, make it possible to inject a glue when creating a
Runtime. Also add a test specify that a CucumberException is thrown
if no backends are found (or an emtpy collection of backends is
injected).
11ac9ff
@brasmusson brasmusson Align the step results in the JUnit test result files
Adjust the number of . separating the step text from the step result,
so that the results are aligned.
87b2ee4
@brasmusson brasmusson Add tests for the JUnitFormatter to disclose issues
The main issue is that the JUnitFormatter does not handle failures
in the before and after hooks properly. To add flexibility the tests
also specify that the JUnitFormatter should handle both all-steps-first
execution and one-step-at-the-time execution.
ebfb7aa
@brasmusson brasmusson Fix issues in the JUnitFormatter
Change the JUnitFormatter to handle failures in the before and after
hooks properly. Also change the JUnitFormatter to handle both
all-steps-first execution and one-step-at-the-time execution.
37d9bcb
@brasmusson brasmusson Revert to all-steps-first scenario execution
To fix the missmatch between the PrettyFormatter from the Gherkin
library and Cucumber-JVM, by reverting the scenario execution to
all-steps-first execution as in Cucumber-JVM 1.1.2. This is possible
since the JSONFormatter in the Gherkin library in Gherkin 2.12.0
supports all-steps-first execution.
1622c69
@brasmusson brasmusson added a commit to brasmusson/cucumber-jvm that referenced this pull request Jul 14, 2013
@brasmusson brasmusson Merge PR #557 into PR #544
Verify that the changes in PR #557 indeed fixes #491 and the other
reports of that the PrettyFormatter is broken.
b98d428
@aslakhellesoy
Cucumber member

LGTM!

@brasmusson brasmusson merged commit 1622c69 into cucumber:master Jul 16, 2013

1 check passed

Details default The Travis CI build passed
@aslakhellesoy
Cucumber member

@brasmusson thanks! Can you also make sure to update History.md for every issue/PR you close?

@brasmusson

@aslakhellesoy The PR:s I got covered, but I make sure to update History.md with issue #491 which I closed.

@brasmusson

@aslakhellesoy #491 added to History.md in 4439178 (when #544 was merged)

@brasmusson brasmusson deleted the brasmusson:all-steps-first-execution branch Aug 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.