Use uri instead of path in CucumberFeature #562

wants to merge 1 commit into


None yet
1 participant

brasmusson commented Jul 27, 2013

When looking at the JSONPrettyFormatter failure on Windows, I originally thought; "Since Cucumber-JVM both on Windows and *nix support '/' in feature path arguments on the command line and Cucumber.Options, why not use '/' in the URI sent to formatters on all platforms?"
Reading up on URI:s revealed that URI:s always use '/' on all platforms, it is only file paths that on Windows use '' (,
Therefore make sure to the featureURI argument sent to the Gherkin parser when creating CucumberFeature is an URI using '/' and not a file path (which on Windows uses '').
This PR has been tested successfully (mvn clean package) on both:
Windows XP
Ubuntu 13.04

@brasmusson brasmusson Use uri instead of path in CucumberFeature
On Windows paths use '\' as separator, but uri:s use '/'. On other
platforms both paths and uri:s use '/' as separator. Make sure that
paths are converted to uri:s when CucumberFeatures are created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment