Skip to content

The RerunFormatter does not handle failures in background and scenario outline examples correctly #589

Merged
merged 4 commits into from Oct 16, 2013

1 participant

@brasmusson

The RerunFormatter does not handle failures in background and scenario outline examples correctly. The use of the line of the failed step works ok in case of ordinary scenarios, but to handle failures in background steps, in examples in scenario outlines and in hooks the line of the scenario needs to be used.

brasmusson added some commits Sep 12, 2013
@brasmusson brasmusson Add failing tests to disclose issues with the RerunFormatter
Add failing tests for the handling of failures in background,
scenario outline examples and hooks in the RerunFormatter.
Move helpers to test formatters to TestHelper.
0110e3f
@brasmusson brasmusson Fix errors in the RerunFormatter, move its testing to core
Fix the rerun formatters handling of failures in background,
scenario outline examples and hooks in the RerunFormatter.
Move all testing of the RerunFormatter to core.
ce6a9c9
@brasmusson brasmusson Move helpers from CucumberPrettyFormatterTest to TestHelper
Move helpers from CucumberPrettyFormatterTest to TestHelper, and
refactor to make the helper share implementation in TestHelper.
806dd14
@brasmusson brasmusson Use the new Formatter interface methods in the RerunFormatter
Simplify the RerunFormatter by taking advantage of the new methods
startOfScenarioLifeCycle and endOfScenarioLifeCycle in the Formatter
interface.
c591426
@brasmusson brasmusson added a commit that referenced this pull request Oct 16, 2013
@brasmusson brasmusson Merge #589. Update History.md 80773f0
@brasmusson brasmusson merged commit c591426 into cucumber:master Oct 16, 2013

1 check passed

Details default The Travis CI build passed
@brasmusson brasmusson deleted the brasmusson:rerun-formatter-fixes branch Oct 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.