Skip to content

Using spring @ContextHierarchy to manage multiple @ContextConfiguration's breaks with 1.1.5 #590

Merged
merged 1 commit into from Oct 15, 2013

4 participants

@martinlau

The new version of SpringFactory includes the code:

    private boolean dependsOnSpringContext(Class<?> type) {
        return type.isAnnotationPresent(ContextConfiguration.class);
    }

This should probably be extended to:

    private boolean dependsOnSpringContext(Class<?> type) {
        return type.isAnnotationPresent(ContextConfiguration.class)
            || type.isAnnotationPresent(ContextHierarchy.class);
    }
@aslakhellesoy
Cucumber member

Can you send a pull request with a test for this please?

@ffbit ffbit was assigned Oct 12, 2013
@aslakhellesoy
Cucumber member

@ffbit I've assigned this one to you. If you're busy, can you pass it on to @pasviegas please?

@pasviegas
@pasviegas

Yeah @aslakhellesoy that's is exactly what is happening. The pr seems good for me.

@aslakhellesoy
Cucumber member

Thanks @pasviegas - can you merge it to master and update History.md please?

@ffbit
Cucumber member
ffbit commented Oct 15, 2013

Great job, @martinlau!

@ffbit ffbit merged commit 2e27783 into cucumber:master Oct 15, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.