Fix for DataTable as parameter in Jython steps #602

Merged
merged 4 commits into from Oct 12, 2013

Conversation

Projects
None yet
2 participants
@lggroapa
Contributor

lggroapa commented Oct 8, 2013

If the argument is a DataTable it is converted to the raw form (List<List) then converted to PyArray so you can pass it as a PyObject

Fix for DataTable as parameter in Jython steps
If the argument is a DataTable it is converted to the raw form (List<List<String>) then converted to PyArray so you can pass it as a PyObject
@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Oct 8, 2013

Contributor

Can you add a test please?

Contributor

aslakhellesoy commented Oct 8, 2013

Can you add a test please?

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Oct 8, 2013

Contributor

Also, please follow coding conventions (4 space indent). See CONTRIBUTING.md

Contributor

aslakhellesoy commented Oct 8, 2013

Also, please follow coding conventions (4 space indent). See CONTRIBUTING.md

@lggroapa

This comment has been minimized.

Show comment Hide comment
@lggroapa

lggroapa Oct 8, 2013

Contributor

Ok i will try to add a test, and ill change to respect the convention, but tomorrow ;)

Contributor

lggroapa commented Oct 8, 2013

Ok i will try to add a test, and ill change to respect the convention, but tomorrow ;)

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@lggroapa

This comment has been minimized.

Show comment Hide comment
@lggroapa

lggroapa Oct 10, 2013

Contributor

Ok added tests and i hope i did the formatting good, sorry about me being slow but the proxy i have dosen't work well with git client so i had to do the commits from browser :)

Contributor

lggroapa commented Oct 10, 2013

Ok added tests and i hope i did the formatting good, sorry about me being slow but the proxy i have dosen't work well with git client so i had to do the commits from browser :)

@aslakhellesoy aslakhellesoy merged commit 440ab51 into cucumber:master Oct 12, 2013

1 check passed

default The Travis CI build passed
Details
@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Oct 12, 2013

Contributor

Thanks @lggroapa. Your tests didn't assert anything, so they weren't really tests ;-)

I added some assertions and realised there was a bug in your code - we have to use PyList instead of PyArray.

Thanks for your contribution!

Contributor

aslakhellesoy commented Oct 12, 2013

Thanks @lggroapa. Your tests didn't assert anything, so they weren't really tests ;-)

I added some assertions and realised there was a bug in your code - we have to use PyList instead of PyArray.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment