Permalink
Commits on May 17, 2018
  1. Merge pull request #389 from cucumber/xtrasimplicity-patch-1

    xtrasimplicity committed May 17, 2018
    CI: Upgrade geckodriver-helper
  2. CI: Upgrade geckodriver-helper

    xtrasimplicity committed May 17, 2018
Commits on Apr 22, 2018
  1. Updated Changelog to reflect latest release

    xtrasimplicity committed Apr 22, 2018
  2. Better newlines?

    mattwynne committed Apr 22, 2018
  3. Merge pull request #388 from cucumber/xtrasimplicity-patch-1

    mattwynne committed Apr 22, 2018
    Requesting release karma
  4. Requesting release karma

    xtrasimplicity committed Apr 22, 2018
  5. Disable display of detailed exceptions (#387)

    xtrasimplicity committed Apr 22, 2018
  6. Removed check for Rails version >= 3.2.1

    xtrasimplicity committed Apr 22, 2018
    As we don't support Rails 3 in Cucumber-rails >= 1.5
  7. Make check conditional to Rails version

    Pedro Moreira authored and xtrasimplicity committed Mar 7, 2016
    This PR depends on action_dispatch.show_detailed_exceptions being set,
    which was only introduced in Rails 3.2.1.
    
    Here we introduce a conditional check based on the required Rails
    version in order to ensure backwards compatibility.
  8. Do not rely on current public error message

    pedrosmmoreira authored and xtrasimplicity committed Jun 4, 2015
    There are slight changes in the error message displayed in the public
    error pages across Rails versions. Checking for "We're sorry, but
    something went wrong." seems to be the safest option.
  9. Disable display of detailed exceptions

    pedrosmmoreira authored and xtrasimplicity committed Jun 3, 2015
    `@allow-rescue` permits rescuing exceptions by setting
    `action_dispatch.show_exceptions` to true in the env hash. However,
    this will render the detailed error page and not the public error page
    you'd encounter in production.
    
    Given that the feature enables testing of error pages, and seems to be
    intended to mirror production behaviour as per the comment on
    https://github.com/cucumber/cucumber-rails/blob/master/lib/generators/cucumber/install/templates/support/_rails_each_run.rb.erb#L6-L14,
    this PR sets `action_dispatch.show_detailed_exceptions` to false, thus
    enabling the public error page to be rendered.
Commits on Apr 21, 2018
Commits on Apr 20, 2018
  1. Merge pull request #378 from gobijan/master

    xtrasimplicity committed Apr 20, 2018
    Add Rails 5.2 & Capybara 3 support.
  2. Merge pull request #4 from radar/click-with-js-emulation-args

    gobijan committed Apr 20, 2018
    Make click_with_javascript_emulation take any args
  3. Merge pull request #5 from radar/use-latest-firefox

    gobijan committed Apr 20, 2018
    Use latest firefox
  4. Merge pull request #6 from xtrasimplicity/BugFix/FixingBootsnapIssues

    gobijan committed Apr 20, 2018
    Fixed bootsnap issues on Rails 5.2
Commits on Apr 19, 2018
  1. Make click_with_javascript_emulation take any args

    radar committed Apr 19, 2018
    During the "Delete Widgets" test, this happens:
    
        When I follow "Destroy"                 # features/step_definitions/web_steps.rb:48
          wrong number of arguments (given 2, expected 0) (ArgumentError)
          /Users/ryanbigg/code/gems/cucumber-rails/lib/cucumber/rails/capybara/javascript_emulation.rb:12:in `click_with_javascript_emulation'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/element.rb:133:in `block in click'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/base.rb:83:in `synchronize'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/element.rb:133:in `click'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/node/actions.rb:41:in `click_link'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/session.rb:740:in `block (2 levels) in <class:Session>'
          /usr/local/Cellar/asdf/0.4.1/installs/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/capybara-3.0.2/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
          /Users/ryanbigg/code/gems/cucumber-rails/tmp/aruba/test_app/features/step_definitions/web_steps.rb:49:in `block in <main>'
    
      This is because Capybara 3 now passes two additional arguments to
      Cucumber's method. But this Cucumber method needs to do nothing with
      those arguments other than accept them.
    
      This will make the "Deleting a widget" test pass once again.
Commits on Apr 18, 2018
  1. Merge pull request #1 from radar/master

    gobijan committed Apr 18, 2018
    Bump geckodriver-helper version to 0.0.5
  2. Fix other occurrences of factory_girl

    radar authored and gobijan committed Apr 18, 2018
  3. factory_girl -> factory_bot

    radar authored and gobijan committed Apr 17, 2018
  4. Add rails 5.2 to appraisals.

    gobijan committed Apr 12, 2018