Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding support for custom JS DB strategies #184

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

mpabst commented Nov 7, 2011

Hey there! We're the guys who made the patch request for the connection pooling thing. We really like the more flexible change you did instead, but unfortunately, we discovered while testing it that it doesn't work with our app, because we use a truncation strategy implemented by our own custom module, instead of DatabaseCleaner (which reminds us, you might want to require DBCleaner in the ... gemspec? we're not really sure, since it's a conditional dependency). We were wondering if you'd accept this patch to allow custom DB strategies. Thanks!

@mattwynne mattwynne closed this in 7656a45 Nov 9, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment