Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Rails 4.2 + ruby-head (2.6) build #400

Merged

Conversation

Projects
None yet
4 participants
@koic
Copy link
Member

commented Dec 10, 2018

Summary

Exclude Rails 4.2 + ruby-head (2.6) build matrix from Travis CI.

Details

This PR excludes the following error matrix from Travis CI.

NoMethodError:
  undefined method `new' for BigDecimal:Class
# /home/travis/.rvm/gems/ruby-head/gems/activesupport-4.2.11/lib/active_support/core_ext/object/duplicable.rb:111:in `<class:BigDecimal>'

https://travis-ci.org/cucumber/cucumber-rails/jobs/462430088#L1569-L1594

Motivation and Context

Rails 4.2 is using BigDecimal.new. However BigDecimal.new was removed from Ruby 2.6.
ruby/ruby@2810c12#diff-64cf76d72ee12a82d3093efe6c2f83f7

% ruby -rbigdecimal -ve 'BigDecimal.new(5.0)'
ruby 2.6.0dev (2018-12-10 trunk 66302) [x86_64-darwin17]
/Users/koic/.rbenv/versions/2.6.0-dev/lib/ruby/site_ruby/2.6.0/rubygems/version.rb:216:
warning: deprecated Object#=~ is called on Integer; it always returns
nil
Traceback (most recent call last):
-e:1:in `<main>': undefined method `new' for BigDecimal:Class (NoMethodError)

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
Exclude Rails 4.2 + ruby-head (2.6) build
## Summary

Exclude Rails 4.2 + ruby-head (2.6) build matrix from Travis CI.

## Details

This PR excludes the following error matrix from Travis CI.

```console
NoMethodError:
  undefined method `new' for BigDecimal:Class
# /home/travis/.rvm/gems/ruby-head/gems/activesupport-4.2.11/lib/active_support/core_ext/object/duplicable.rb:111:in
`<class:BigDecimal>'
```

https://travis-ci.org/cucumber/cucumber-rails/jobs/462430088#L1569-L1594

## Motivation and Context

Rails 4.2 is using `BigDecimal.new`. However `BigDecimal.new` was
removed from Ruby 2.6.
ruby/ruby@2810c12#diff-64cf76d72ee12a82d3093efe6c2f83f7

```console
% ruby -rbigdecimal -ve 'BigDecimal.new(5.0)'
ruby 2.6.0dev (2018-12-10 trunk 66302) [x86_64-darwin17]
/Users/koic/.rbenv/versions/2.6.0-dev/lib/ruby/site_ruby/2.6.0/rubygems/version.rb:216:
warning: deprecated Object#=~ is called on Integer; it always returns
nil
Traceback (most recent call last):
-e:1:in `<main>': undefined method `new' for
BigDecimal:Class (NoMethodError)
```

@koic koic force-pushed the koic:exclude_rails_4_2_with_ruby_2_6 branch from 4de366c to e4b7e5f Dec 10, 2018

@deivid-rodriguez deivid-rodriguez merged commit c19c9fd into cucumber:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@koic koic deleted the koic:exclude_rails_4_2_with_ruby_2_6 branch Dec 10, 2018

@mrkn

This comment has been minimized.

Copy link

commented Dec 14, 2018

I decided to revert removing BigDecimal.new for the next version of bigdecimal.
Anyway, I think you can stick the version of bigdecimal to 1.3.5 now.

koic added a commit to koic/cucumber-rails that referenced this pull request Dec 24, 2018

Revert "Exclude Rails 4.2 + ruby-head (2.6) build"
## Summary

This reverts commit e4b7e5f.

## Details

This PR restores Rails 4.2 + ruby-head (2.6) build.

`BigDecimal.new` has been replaced with deprecation rather than deletion.

```console
% ruby -rbigdecimal -ve 'BigDecimal.new(42)'
ruby 2.6.0dev (2018-12-24 trunk 66524) [x86_64-darwin17]
-e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.
```

## Motivation and Context

Follow up of cucumber#400 (comment).

@koic koic referenced this pull request Dec 24, 2018

Merged

Revert "Exclude Rails 4.2 + ruby-head (2.6) build" #402

0 of 3 tasks complete
@koic

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2018

I reverted this change by #402. Thanks @mrkn!

koic added a commit to koic/cucumber-rails that referenced this pull request Dec 26, 2018

Revert "Exclude Rails 4.2 + ruby-head (2.6) build"
## Summary

This reverts commit e4b7e5f.

## Details

This PR restores Rails 4.2 + ruby-head (2.6) build.

`BigDecimal.new` has been replaced with deprecation rather than deletion.

```console
% ruby -rbigdecimal -ve 'BigDecimal.new(42)'
ruby 2.6.0dev (2018-12-24 trunk 66524) [x86_64-darwin17]
-e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.
```

## Motivation and Context

Follow up of cucumber#400 (comment).

sue445 added a commit to sue445/komachi_heartbeat that referenced this pull request Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.