New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #1215

Open
aslakhellesoy opened this Issue Oct 11, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@aslakhellesoy
Copy link
Contributor

aslakhellesoy commented Oct 11, 2017

@bv

This comment has been minimized.

Copy link
Contributor

bv commented Nov 19, 2017

@aslakhellesoy, do you believe there is still anything to be fixed?
Currently

Thanks.

@brasmusson

This comment has been minimized.

Copy link
Contributor

brasmusson commented Nov 21, 2017

There are 97 scenarios in the feature files in the features directory with the tag @todo-windows, which I think means that the scenario is not executed on Windows.

@bv

This comment has been minimized.

Copy link
Contributor

bv commented Nov 21, 2017

thank you Björn, now I got the idea, and can reproduce failing 77 scenarios out of 97.

@stale

This comment has been minimized.

Copy link

stale bot commented Jan 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the Stale label Jan 20, 2018

@bv bv removed the Stale label Jan 20, 2018

@jaysonesmith

This comment has been minimized.

Copy link
Member

jaysonesmith commented Jan 20, 2018

@bv Taking a look through issues: Are you still working on this?

@bv

This comment has been minimized.

Copy link
Contributor

bv commented Jan 24, 2018

@jaysonesmith trying to figure out why it is special about win platform

@jaysonesmith

This comment has been minimized.

Copy link
Member

jaysonesmith commented Jan 27, 2018

Pasting a bit of what I've said in the committer-ruby channel on Slack here:

There's what seems to be a pretty common issue finding expected files (maybe easy-ish to sort out depending on the cause) but there's another, more complicated issue I think.

It seems like scenarios, or the files they create, are bleeding into other scenarios and causing them to fail.

[9:32 PM]
I've spent a good amount of time going through scenarios marked todo-windows and running them to see what works/doesn't.

[9:33 PM]
Unfortunately, things that pass on their own may not when one or more other scenarios from the same file are run OR scenarios from other features are. On top of that, some situations can cause the number of scenarios that fail to differ.

[9:33 PM]
For instance: bundle exec cucumber --profile windows_mri --order random features\docs\defining_steps\

[9:34 PM]
On multiple, back to back runs, I could see 8 failures, then 7, then 9, then 8, and then 10.

[9:37 PM]
On the last run of 10 failures, here's what failed:

nested_steps.feature:15
nested_steps_with_second_arg.feature:37
nested_steps_i18n.feature:17
nested_steps.feature:34
nested_steps.feature:80
nested_steps_with_second_arg.feature:9
ambiguous_steps.feature:55
nested_steps.feature:51

[9:37 PM]
In running each of those scenarios individually, every single one passed.

[9:38 PM]
If I do: bundle exec cucumber -p windows_mri features/docs/defining_steps/skip_scenario.feature:3 features/docs/defining_steps/nested_steps.feature:15 the second scenario fails.

[9:38 PM]
If I switch their places, the latter scenario again fails

@stale

This comment has been minimized.

Copy link

stale bot commented Mar 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the Stale label Mar 28, 2018

@xtrasimplicity

This comment has been minimized.

Copy link
Member

xtrasimplicity commented Mar 28, 2018

Reopened, as this is still an issue.

@stale stale bot removed the Stale label Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment