New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frozen-string-literal fixes in eval'd code. #1136

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
6 participants
@pat
Contributor

pat commented Jun 28, 2017

Summary

The pragma comment doesn't pick up these uses because the code is eval'd on the fly.

Related:

How Has This Been Tested?

I've managed to get the test suite passing locally with the --enable-frozen-string-literal RUBYOPT flag, using my own copy of Aruba plus some related upgrading changes because Cucumber's been locked to an old Aruba version for quite some time. I've also used the rspec-core test suite (which makes use of Cucumber) and my local cucumber copy to confirm their test suite is green as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Given the pragma comments, I'm presuming being frozen-string-literal-friendly is a goal of Cucumber, hence pretty confident in labelling this a bug fix :)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

None of the checklist items here apply.

@danascheider

This comment has been minimized.

Show comment
Hide comment
@danascheider

danascheider Jul 5, 2017

Contributor

@pat Some of the AppVeyor failures are fixed on master now - if you can rebase we can see if that fixes everything. Thanks for your help!

Contributor

danascheider commented Jul 5, 2017

@pat Some of the AppVeyor failures are fixed on master now - if you can rebase we can see if that fixes everything. Thanks for your help!

@pat

This comment has been minimized.

Show comment
Hide comment
@pat

pat Jul 18, 2017

Contributor

@danascheider it seems the AppVeyor build's still broken? Or at the very least, I don't think my changes are the source of the problem… but I don't have a Windows machine at hand to test with.

If there's any debugging help I can do though, do let me know!

Contributor

pat commented Jul 18, 2017

@danascheider it seems the AppVeyor build's still broken? Or at the very least, I don't think my changes are the source of the problem… but I don't have a Windows machine at hand to test with.

If there's any debugging help I can do though, do let me know!

@enkessler

This comment has been minimized.

Show comment
Hide comment
@enkessler

enkessler Jul 18, 2017

Contributor

The AppVeyor build was very briefly green at its start but didn't stay that way. It probably doesn't help that the Slack bot only posts about the Travis builds but the AppVeyor builds fail more quietly.

Contributor

enkessler commented Jul 18, 2017

The AppVeyor build was very briefly green at its start but didn't stay that way. It probably doesn't help that the Slack bot only posts about the Travis builds but the AppVeyor builds fail more quietly.

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the Stale label Nov 8, 2017

@pat

This comment has been minimized.

Show comment
Hide comment
@pat

pat Nov 8, 2017

Contributor

Can someone more knowledgeable let me know whether I should expect Appveyor to go green? Would rebasing this PR help matters? I don't feel I'm doing anything here that's going to behave differently on Windows.

Contributor

pat commented Nov 8, 2017

Can someone more knowledgeable let me know whether I should expect Appveyor to go green? Would rebasing this PR help matters? I don't feel I'm doing anything here that's going to behave differently on Windows.

@stale stale bot removed the Stale label Nov 8, 2017

@mattwynne

This comment has been minimized.

Show comment
Hide comment
@mattwynne

mattwynne Nov 8, 2017

Member

@pat I think a rebase should help, yes. The appveyor build has been green recently.

Member

mattwynne commented Nov 8, 2017

@pat I think a rebase should help, yes. The appveyor build has been green recently.

Frozen-string-literal fixes in eval'd code.
The pragma comment doesn't pick up these uses because the code is eval'd on the fly.
@pat

This comment has been minimized.

Show comment
Hide comment
@pat

pat Nov 8, 2017

Contributor

Indeed, looks like it's green now with the rebase :)

Contributor

pat commented Nov 8, 2017

Indeed, looks like it's green now with the rebase :)

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Jan 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

stale bot commented Jan 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the Stale label Jan 7, 2018

@pat

This comment has been minimized.

Show comment
Hide comment
@pat

pat Jan 7, 2018

Contributor

Anything further I can do that'd be useful in getting this merged? :) The build is green! 💚

Contributor

pat commented Jan 7, 2018

Anything further I can do that'd be useful in getting this merged? :) The build is green! 💚

@stale stale bot removed the Stale label Jan 7, 2018

@olleolleolle

LGTM!

@olleolleolle olleolleolle merged commit 89d5d93 into cucumber:master Jan 8, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@aslakhellesoy

This comment has been minimized.

Show comment
Hide comment
@aslakhellesoy

aslakhellesoy Jan 8, 2018

Contributor

Hi @pat,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Contributor

aslakhellesoy commented Jan 8, 2018

Hi @pat,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mattwynne

This comment has been minimized.

Show comment
Hide comment
@mattwynne

mattwynne Jan 10, 2018

Member

Welcome @pat!

Member

mattwynne commented Jan 10, 2018

Welcome @pat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment