New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint/DeprecatedClassMethods #1172

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@jaysonesmith
Copy link
Member

jaysonesmith commented Aug 10, 2017

Summary

Fix Lint/DeprecatedClassMethods

Details

  • Offense count: 1

Motivation and Context

Working to help solve issue 1021!

How Has This Been Tested?

bundle exec rake 馃憤

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
Fix Lint/DeprecatedClassMethods
* Offense count: 1
@nodo

nodo approved these changes Aug 14, 2017

Copy link
Member

nodo left a comment

Thanks for contributing @jaysonesmith ! The PR looks good to me, I have restarted travis tests.

@jaysonesmith

This comment has been minimized.

Copy link
Member

jaysonesmith commented Aug 14, 2017

Tyvm!

@nodo nodo merged commit 4de7f6d into cucumber:master Aug 14, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aslakhellesoy

This comment has been minimized.

Copy link
Contributor

aslakhellesoy commented Aug 14, 2017

Hi @jaysonesmith,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 馃嵕

In return for we ask you to:

  • Please continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 馃挌 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 馃挰 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • 鈩癸笍 Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 馃檵 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Helles酶y
Creator of Cucumber

@jaysonesmith jaysonesmith deleted the jaysonesmith:1021-fix-style-violations-1 branch Aug 14, 2017

@jaysonesmith

This comment has been minimized.

Copy link
Member

jaysonesmith commented Aug 14, 2017

History.md has been updated. PR coming soon. (Including my other PRs)

@lock

This comment has been minimized.

Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.