Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cucumber pro publish job #1350

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
3 participants
@luke-hill
Copy link
Contributor

commented May 3, 2019

Details

Removing a failing task from circleCI

Motivation and Context

It's long been failing, and was added a while back: 24e3a2e

In the SHA @mattwynne you mention adding an SSH key. Was this done? As it keeps failing for invalid authentication

Just trying to tidy up the build process with @olleolleolle to get everything green and trustworthy again

@luke-hill luke-hill requested review from olleolleolle and mattwynne May 3, 2019

@olleolleolle
Copy link
Contributor

left a comment

This can be re-instated when there's energy for it.

@luke-hill

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@mattwynne Are we ok to merge this?

@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from 7560899 to 84b8eb4 May 23, 2019

@luke-hill luke-hill force-pushed the master branch from 6886df5 to cacfed8 May 23, 2019

@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from 84b8eb4 to d423b4e May 27, 2019

@luke-hill luke-hill force-pushed the feature/remove_failing_publish_task branch from d423b4e to 352210c May 28, 2019

@mattwynne

This comment has been minimized.

Copy link
Member

commented May 29, 2019

For sure! It would be good to set up publishing to Jam but we don't need to do it like this anymore.

@luke-hill luke-hill merged commit 07e1287 into master May 31, 2019

3 of 7 checks passed

ci/circleci: jruby Your tests failed on CircleCI
Details
ci/circleci: ruby-2.2 Your tests failed on CircleCI
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details

@luke-hill luke-hill deleted the feature/remove_failing_publish_task branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.