Skip to content

Conversation

@brasmusson
Copy link
Contributor

The Travis builds for JRuby have been failing for a while because a scenario tagged @wip-jruby fails there. To me it seems like the options "--tags ~@wip-jruby" should be used for the JRuby build. Therefore that option need to be added to std_opts in cucumber.yml on JRuby.
The wip_opts for JRuby in cucumber.yml looks broken ",@wip-jruby" cannot be added to a string ending with "-r features". It first caught my eye in cucumber.yml, therefore I fixed that first (thinking that it should fix the JRuby build).

Fix so that "-r features" does not block the @wip-jruby wip option
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling f55d48a on brasmusson:wip-jruby-fix into ab427d0 on cucumber:master.

Add "--tags ~@wip-jruby" to the std_opts.
@brasmusson
Copy link
Contributor Author

Right now Travis get connection refused when trying to install rake, so I or someone else need to restart the build, when that problem has been resolved.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1fab8ef on brasmusson:wip-jruby-fix into ab427d0 on cucumber:master.

os97673 added a commit that referenced this pull request Nov 15, 2013
Trying to fix the failing JRuby builds on Travis
@os97673 os97673 merged commit 3e2266a into cucumber:master Nov 15, 2013
@os97673
Copy link
Member

os97673 commented Nov 15, 2013

Thank you for fixing this annoying problem.

@brasmusson brasmusson deleted the wip-jruby-fix branch November 15, 2013 10:42
@mattwynne
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants