Update json formatter for append images embedding

[arturgspb]

Before fix, code like this does not append embedding info to json. I fixed it.
Code example:
page.driver.browser.save_screenshot("report/#{scenario.id}.png")
embed("#{scenario.id}.png", "image/png", "SCREENSHOT")

[os97673]

please add test for the problem.

[arturgspb]

I'll try it, but my ruby experience - 4 days ;)

[ghost]

this fix does not work for me
def initialize(runtime, io, options)
@io = ensure_io(io, "json")

•    super(Gherkin::Formatter::JSONFormatter.new(@io), false)
  

•    @formatter = Gherkin::Formatter::JSONFormatter.new(@io)
  

•    super(@formatter, false)
  

•  end
  

•  def embed(src, mime_type, label)
  

•    @formatter.embedding(mime_type, {'label' => label, 'src' => src}.to_json)
  end
  

  end
  end

It injects something into json file but it isn't screen path.

Example of my json file

"embeddings": [
{
"mime_type": "image/png",
"data": "eyJsYWJlbCI6IlNDUkVFTlNIT1QiLCJzcmMiOiI3MDI5NDQyMzAwNTI4MC5wbmcifQ=="
}

[arturgspb]

@skaliberda, I think too little description of the problem. Describe the steps reproduce the problem, what should happen and what actually happens.

[brasmusson]

This kind of feature is implemented by #695 and has been release in both v1.3.17 and v2.0.0.beta.2.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.