Handle hook output appropriately in the Pretty formatter #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brasmusson
force-pushed
the
pretty-formatter-hook-output
branch
from
7914e5c
to
f94d745
Compare
For the Pretty formatter it is important that the output (puts) from After/AfterStep hook arrive before the call to after_table_row, and that the exceptions from from After/AfterStep hooks arrive after the call to after_table_row.
brasmusson
force-pushed
the
pretty-formatter-hook-output
branch
from
f94d745
to
66c9c82
Compare
|
In case of Scenario Outlines, it is really important for the Pretty formatter that the hook output (calls to formatter.puts) arrive before the call to formatter.after_table_row, and really, really important the the hook exceptions arrive after the call to formatter.after_table_row. So ... well the complexity of legacy_formatter was not exactly reduced. |
|
On 14 Sep 2014, at 15:39, Björn Rasmusson notifications@github.com wrote:
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Pretty formatter are delaying the output from hooks, see the failing test.