Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scenario selection #786

Merged
merged 3 commits into from Dec 30, 2014
Merged

Fix scenario selection #786

merged 3 commits into from Dec 30, 2014

Conversation

jdks
Copy link
Contributor

@jdks jdks commented Dec 28, 2014

In response to issue #778

Previously, duplicate files within the file_specs where executed twice and
affected the execution order of scenarios. This change ensures only unique
files are returned from file specs.

In response to issue #778

Previously, duplicate files within the `file_specs` where executed twice and
affected the execution order of scenarios. This change ensures only unique
files are returned from file specs.
@mattwynne
Copy link
Member

This is great, thanks @jdks

I'm glad we have the neat abstraction of the FileSpec class so this can be unit-tested. I think we can lose the acceptance test. What do you think?

@jdks
Copy link
Contributor Author

jdks commented Dec 28, 2014

@mattwynne yeah, that makes sense. I've updated the pull request 👍

mattwynne added a commit that referenced this pull request Dec 30, 2014
@mattwynne mattwynne merged commit a8050ee into cucumber:master Dec 30, 2014
@jdks jdks deleted the fix-scenario-selection branch December 30, 2014 14:59
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants