gherkin-dotnet: Support for .NET Standard 2.0 #259

Closed
rafaelromao opened this Issue Aug 23, 2017 · 5 comments

Comments

Projects
None yet
3 participants

Summary

.NET Standard 2.0 is not supported.

Trying to use the Gherkin parser under .NET Core 2.0 and .NET Standard 2.0 will cause a fallback to .NET 4.x and the parser will try and fail to load System.Web.Extensions.

Expected Behavior

Parse feature files successfully using .NET Core 2.0 and .NET Standard 2.0.

Current Behavior

Considering a web project targeting netcoreapp2.0 that consumes a library targeting netstandard2.0 and this library tries to use the Gherkin parser.

The parser try to load System.Web.Extensions on Gherkin.GherkinDialectProvider.ParseJsonContent() and fail with a System.IO.FileNotFoundException: Could not load file or assembly 'System.Web.Extensions' exception.

Possible Solution

Update the project to support .NET Standard 2.0.

Your Environment

Windows 10, Visual Studio Code, dotnet core SDK 2.0.0, dotnet core 2.0.0.

Owner

aslakhellesoy commented Aug 23, 2017

This is mostly done in #174 I think

Looks like it will be fixed after this PR, but something went wrong in the build, although it passed. The version number was not upgraded and the nuget package was not published. https://ci.appveyor.com/project/aslakhellesoy/gherkin

Contributor

SabotageAndi commented Sep 11, 2017

No idea why AppVeyor does not find the nuget package and uploads it.

Contributor

SabotageAndi commented Sep 11, 2017

Ok, after some small changes in cucumber/gherkin-dotnet#10, the build finds the nuget package and creates a correct looking version number for it.

Owner

aslakhellesoy commented Oct 6, 2017

I believe this is fixed now. Let me know if I got it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment