Cucumber Expressions Ruby - 1line fix #306

Closed
aslakhellesoy opened this Issue Nov 28, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@aslakhellesoy
Owner

aslakhellesoy commented Nov 28, 2017

From @luke-hill on November 16, 2017 15:59

I've not managed to get the repo cloned yet in my spare time, however I'll try contribute where possible.

Here is a nice 1line tidy bugfix.

Change
https://github.com/cucumber/cucumber-expressions-ruby/blob/master/lib/cucumber/cucumber_expressions/parameter_type.rb#L41

to

"Single transformer unexpectedly matched 2 values - \"#{non_nil_group_values[0]}\" and \"#{non_nil_group_values[1]}\""

$ syntax from java leakover I imagine.

Copied from original issue: cucumber/cucumber-ruby#1234

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Nov 28, 2017

Owner

From @olleolleolle on November 16, 2017 16:7

@luke-hill There's cool pen icon you can use on GitHub, which forks-and-edits a file.

Owner

aslakhellesoy commented Nov 28, 2017

From @olleolleolle on November 16, 2017 16:7

@luke-hill There's cool pen icon you can use on GitHub, which forks-and-edits a file.

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Nov 28, 2017

Owner

From @enkessler on November 16, 2017 16:9

Now it just needs a test. :)

Owner

aslakhellesoy commented Nov 28, 2017

From @enkessler on November 16, 2017 16:9

Now it just needs a test. :)

@aslakhellesoy

This comment has been minimized.

Show comment Hide comment
@aslakhellesoy

aslakhellesoy Nov 28, 2017

Owner

From @luke-hill on November 16, 2017 16:41

I plan on contributing here and to selenium as and when I get around to setting up machine after having completed my ruby training (Last month), I can now start OS contributions

Owner

aslakhellesoy commented Nov 28, 2017

From @luke-hill on November 16, 2017 16:41

I plan on contributing here and to selenium as and when I get around to setting up machine after having completed my ruby training (Last month), I can now start OS contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment