Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

event-protocol: Add test-run started event #161

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

mattwynne commented Mar 18, 2017 edited

Summary

Add a test-run-started event. This contains contextual information about the test run.

Details

More PRs coming for test results events

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
@mattwynne mattwynne event-protocol: Add test-run started event
More PRs coming for test results events
62ceda9
Owner

aslakhellesoy commented Mar 20, 2017

We probably need this.

Going forward I would like to see additions or changes to the event protocol to be done in the same commit as the consumer(s) requiring that change. This means that consumers driving the change to the protocol will have to be added to this repo.

@mattwynne mattwynne closed this Mar 26, 2017

Owner

mattwynne commented Mar 26, 2017

I'll do this differently I think, and propose all the test result events together so we can review the whole lot at the same time.

Owner

mattwynne commented Mar 26, 2017

I agree about having the consumer in the same PR in general, but I'm worried it will make for a very big PR if we have the GUI and the protocol changes all in one. I'm planning to send one for the GUI and another for the protocol, building on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment