New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin-go: gherkin event stream and pickles #162

Merged
merged 5 commits into from Mar 20, 2017

Conversation

Projects
None yet
2 participants
@l3pp4rd
Member

l3pp4rd commented Mar 20, 2017

Summary

closes #145
closes #137

Details

  • general Implements gherkin event stream and pickles.
  • minor fixes go 1.8 build support
  • minor follows idiomatic golang rules and formats code with gofmt and runs go vet on Makefile assertions.
  • minor adapts parser, to support explicit parseError in order to be able to send ndjson error events.
  • minor builds bin/gherkin CLI binary, which can be used for source, ast, errors, pickles event processing.

How Has This Been Tested?

Passes testdata like other cucumber implementations

Checklist:

  • not sure whether all errors should be sent as ndjson events? Currently some of non AST related errors are printed to STDERR, such as a failure to open a feature file for reading.
  • it would be possible to parse features in parallel, but the question is whether it could be supported by consumers. Guess not considered yet..

l3pp4rd added some commits Mar 20, 2017

compatible with go vet tool
in order to follow idiomatic golang process
formats the parser.go with gofmt tool
fixes other go vet reported issues, like
unreachable code or invalid printf arg types
implements pickles into event stream
passes pickle and source tests
@aslakhellesoy

This comment has been minimized.

Contributor

aslakhellesoy commented Mar 20, 2017

Thanks @l3pp4rd great work!

I think it's fine to print non-parser events such as reading files to stderr and exit with 1. That's fatal.

Regarding parallel parsing, let's defer that until there is a need. For now I think it's fast enough that sequential parsing is sufficient.

@aslakhellesoy aslakhellesoy merged commit 71dd7fc into master Mar 20, 2017

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@aslakhellesoy aslakhellesoy deleted the gherkin-go-cli branch Mar 20, 2017

@l3pp4rd

This comment has been minimized.

Member

l3pp4rd commented Mar 20, 2017

thanks, but I wanted to update error handling regarding this question. since currently it does not exit with 1, but keeps trying other feature files. I'll submit another PR later, it is clear now how I should handle it. cheers.

aslakhellesoy added a commit that referenced this pull request Apr 2, 2017

@lock

This comment has been minimized.

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.