New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin: Fix gherkin/javascript/examples so Gherkin loads in browser #197

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
1 participant
@aslakhellesoy
Contributor

aslakhellesoy commented May 3, 2017

Summary

Assign Gherkin to window if it's defined

Details

The example in gherkin/javascript/examples threw an error in the browser, complaining that Gherkin was not defined

Motivation and Context

Needed to use Gherkin in a browser.

Related to cucumber-attic/gherkin#204

How Has This Been Tested?

Running the example manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aslakhellesoy aslakhellesoy merged commit 284be69 into master May 3, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

aslakhellesoy added a commit that referenced this pull request May 3, 2017

@aslakhellesoy aslakhellesoy deleted the gherkin-javascript-fix-browser-build branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment